Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add index on tx.sender, and clean up #1921

Merged
merged 1 commit into from
May 17, 2024
Merged

add index on tx.sender, and clean up #1921

merged 1 commit into from
May 17, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

  • "The personal transactions" displayed on tenscan are very slow because there is no index on the tx. sender
  • the host db took over some responsibilities that were in the enclave before

What changes were made as part of this PR

  • add index
  • remove dead code
  • clarify some method naming

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@badgersrus badgersrus self-requested a review May 17, 2024 09:11
badgersrus
badgersrus approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@badgersrus badgersrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. LGTM

@tudor-malene tudor-malene merged commit 9e1224f into main May 17, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/personal_tx_fix branch May 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badgersrus badgersrus badgersrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tudor-malene @badgersrus